Skip to content

LW-358 [FEAT] Add a top-level LLMWhisperer marketplace landing route for the AWS Marketplace redirect#2152

Merged
athul-rs merged 3 commits into
mainfrom
LW-358-llmw-marketplace-landing-route
Jul 8, 2026
Merged

LW-358 [FEAT] Add a top-level LLMWhisperer marketplace landing route for the AWS Marketplace redirect#2152
athul-rs merged 3 commits into
mainfrom
LW-358-llmw-marketplace-landing-route

Conversation

@athul-rs

@athul-rs athul-rs commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

What

  • Adds the top-level route /llm-whisperer/marketplace-landing to Router.jsx, wired to the LLMWhisperer marketplace landing page plugin (cloud), sitting outside RequireAuth exactly like the existing Unstract marketplace entries.

Why

Tackle's post-purchase redirect is one static URL per listing and cannot carry a per-buyer :orgName segment. LLMWhisperer only had the org-scoped llm-whisperer/:orgName/marketplace-landing route, so the LLMWhisperer AWS Marketplace listings had no valid redirect URL to configure — and pointing them at the existing /marketplace-landing would fire the Unstract claim for an LLMWhisperer purchase (wrong product provisioned). Found during the 2026-07-07 staging marketplace E2E (staging findings log #1).

How

  • New lazyPlugin entry importing the LLMWhisperer MarketplaceLandingPage (cloud plugin) + a <Route path="/llm-whisperer/marketplace-landing"> alongside the Unstract marketplace entries.
  • The page itself (shipped in unstract-cloud [MISC] Track usage in PostHog by default #1622) already handles unauthenticated buyers (redirects through signup preserving the query params) and claims against the portal backend (/api/v1/llmwhisperer/marketplace/claim/) with no orgId in the URL.
  • Route ranking: the static two-segment path outranks the llm-whisperer subtree's :orgName dynamic match, so in-app org-scoped navigation is unaffected.

Can this PR break any existing features? If yes, please list possible items. If no, please explain why. (PS: Admins do not merge the PR without this section filled)

No. Additive route only. In OSS builds the plugin import resolves to the optional-plugin stub (vite optionalPluginImports) and the route harmlessly renders NotFound — verified: OSS vite build succeeds with the stub. Cloud builds ship the real plugin. Existing routes and ranking are untouched.

Relevant Docs

  • llmwhisperer-portal docs/marketplace/ROLLOUT.md ("Post-purchase redirect: the shared frontend marketplace landing — LLMWhisperer variant")

Related Issues or PRs

Dependencies Versions / Env Variables

  • None. After deploy, the LLMWhisperer Tackle listings' redirect URL becomes https://<env>/llm-whisperer/marketplace-landing?marketplace=aws.

Notes on Testing

  • vite build green (stub path, OSS); biome check clean on the changed file.
  • End-to-end redirect → claim flow to be exercised on staging against the LLMWhisperer [TEST] listing once deployed (Phase 1 of the staging E2E plan).

Screenshots

n/a

Checklist

I have read and understood the Contribution Guidelines.

🤖 Generated with Claude Code

…r the Tackle redirect

Tackle's post-purchase redirect is one static URL per listing and cannot
carry a per-buyer :orgName segment. The Unstract listings redirect to the
existing top-level /marketplace-landing, but LLMWhisperer had only the
org-scoped llm-whisperer/:orgName/marketplace-landing route — leaving the
LLMWhisperer listings with no valid redirect target, and the top-level
/marketplace-landing would fire the UNSTRACT claim for an LLMWhisperer
purchase.

Adds /llm-whisperer/marketplace-landing (outside RequireAuth, mirroring
the Unstract entries; the page handles its own auth and claims against
the portal backend). In OSS builds the plugin import resolves to the
optional-plugin stub and the route 404s harmlessly.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 639b09ef-92a1-48f0-b584-c9b11b8bed15

📥 Commits

Reviewing files that changed from the base of the PR and between e0733f8 and c43a1b1.

📒 Files selected for processing (1)
  • frontend/src/routes/Router.jsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/routes/Router.jsx

Summary by CodeRabbit

  • New Features
    • Added a new LLM Whisperer marketplace landing page for buyers at /llm-whisperer/marketplace-landing.
    • The page is integrated into the authenticated app experience, using the app’s existing loading and error handling for a smoother navigation flow.

Walkthrough

Adds a lazily loaded LLMWhisperer marketplace landing entry and registers a route for /llm-whisperer/marketplace-landing in Router.jsx.

Changes

Marketplace Landing Route

Layer / File(s) Summary
Lazy entry and route registration
frontend/src/routes/Router.jsx
Adds LlmWhispererMarketplaceLandingEntry as a lazy plugin entry and routes /llm-whisperer/marketplace-landing to it.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding a top-level LLMWhisperer marketplace landing route.
Description check ✅ Passed The PR description covers What, Why, How, breaking changes, testing, docs, related issues, and checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch LW-358-llmw-marketplace-landing-route

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds a new top-level route /llm-whisperer/marketplace-landing to Router.jsx, wired to the LLMWhisperer-specific MarketplaceLandingPage cloud plugin, so that the LLMWhisperer AWS Marketplace Tackle listing has a valid static redirect URL that fires the correct portal claim endpoint rather than the Unstract one.

  • New lazyPlugin entry imports MarketplaceLandingPage from ../plugins/llm-whisperer/pages/MarketplaceLandingPage.jsx and the route is registered outside RequireAuth, exactly mirroring the existing /marketplace-landing and /marketplace-stripe-conflict entries.
  • Route ranking is safe: /llm-whisperer/marketplace-landing (two static segments) scores higher than the auth-gated llm-whisperer/:orgName/… dynamic subtree in React Router v6's scoring algorithm, so in-app org-scoped navigation is unaffected.
  • In OSS builds the lazyPlugin import resolves to the stub and the guarded {LlmWhispererMarketplaceLandingEntry && <Route/>} renders nothing, so there is no OSS regression.

Confidence Score: 5/5

Purely additive route registration with no changes to existing routes, auth wrappers, or business logic — safe to merge.

The change is a single new lazyPlugin constant and one new Route element, following the exact pattern already used for /marketplace-landing and /marketplace-stripe-conflict. The route is correctly placed outside RequireAuth, the static two-segment path outranks the dynamic :orgName subtree in React Router v6's scoring, and the OSS stub path is handled identically to every other cloud-only plugin route. No existing route ordering, auth boundary, or component is touched.

No files require special attention.

Important Files Changed

Filename Overview
frontend/src/routes/Router.jsx Adds LlmWhispererMarketplaceLandingEntry lazyPlugin constant and a /llm-whisperer/marketplace-landing route outside RequireAuth, consistent with the existing marketplace entry pattern; no conflicts or regressions identified.

Reviews (3): Last reviewed commit: "Merge branch 'main' into LW-358-llmw-mar..." | Re-trigger Greptile

@athul-rs athul-rs requested a review from jaseemjaskp July 8, 2026 09:12

@jaseemjaskp jaseemjaskp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review Toolkit — comprehensive review (Code Reviewer, Silent Failure Hunter, Type Design Analyzer, PR Test Analyzer, Comment Analyzer, Code Simplifier).

Verdict: Approve. This 14-line change registers a lazy-loaded, code-split route (/llm-whisperer/marketplace-landing) that mirrors the existing MarketplaceLandingEntry pattern exactly. Error handling is correctly delegated to lazyPlugin (absent-plugin → NotFound in OSS, everything else re-thrown). No blocking issues found across any dimension.

Verified independently:

  • Route ranking: React Router v6.11.2 ranks fully-static segments above dynamic :orgName, so /llm-whisperer/marketplace-landing ([static, static]) always wins over the org-scoped :orgName/marketplace-landing — no collision, regardless of declaration order or the RequireAuth boundary.
  • Silent failures: none introduced; reuses the intentional, documented lazyPlugin error mapping.
  • Type design: no type surface (JSX route wiring).
  • Tests: no routing-test convention exists in frontend/src (4 test files, none touch routing); a Router unit test would be brittle, low-signal, and inconsistent with the codebase — not requested.
  • Simplification: already minimal and pattern-consistent; nothing to change.

Two optional nits inline (comment wording) plus one low verification note. All non-blocking.

Comment thread frontend/src/routes/Router.jsx Outdated
Comment thread frontend/src/routes/Router.jsx
athul-rs and others added 2 commits July 8, 2026 16:58
Don't pin the concrete portal endpoint (lives in a separate gitignored plugin;
a rename can't be caught here) and lowercase 'portal backend' so it doesn't
read as a defined proper noun. Comment intent (don't consolidate the two
MarketplaceLandingPage entries) is unchanged.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Frontend Lint Report (Biome)

All checks passed! No linting or formatting issues found.

@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2026

Copy link
Copy Markdown

@athul-rs athul-rs merged commit a03217a into main Jul 8, 2026
12 checks passed
@athul-rs athul-rs deleted the LW-358-llmw-marketplace-landing-route branch July 8, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants